Improve 'Unable to open baseline file' message #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0.10.5, hardcode flake8==3.5.0
domanchi
approved these changes
Oct 29, 2018
detect_secrets/pre_commit_hook.py
Outdated
| 'Unable to open baseline file: %s.', filename, | ||
| 'Unable to open baseline file: {}\n' | ||
| 'Please create it via\n' | ||
| ' `detect-secrets scan > .secrets.baseline`\n' |
There was a problem hiding this comment.
Suggested change
| ' `detect-secrets scan > .secrets.baseline`\n' | |
| ' `detect-secrets scan > {}`\n' |
Remember that we never explicitly enforce a certain baseline filename to be used.
There was a problem hiding this comment.
++ I kind of like suggesting it but you're right it's more consistent this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix
--import->--updatecomment,bump to 0.10.5,
hardcode flake8==3.5.0