Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit-hook] Automatically update the baseline #96

Merged
merged 1 commit into from
Nov 26, 2018

Conversation

KevinHock
Copy link
Collaborator

@KevinHock KevinHock commented Nov 22, 2018

When no secrets are present, that is.

(pre_commit_hook.py)
Do not raise exception when baseline out-of-date
Replace baseline version/plugins with the current ones.
Replaced raise_exception_if_baseline_version_is_outdated with if statement
Renamed raise_exception_if_baseline_file_is_not_up_to_date to raise_exception_if_baseline_file_is_unstaged
Improve comment

(core/secrets_collection.py)
Make version not required for baseline's any more

(tests/pre_commit_hook_test.py):
Replaced test_fails_if_baseline_version_is_outdated with test_that_baseline_gets_updated

Clean up:
(core/usage.py)
Static list into a tuple
(core/baseline.py)
initialize() docstring accurate
Renamed update_baseline_with_removed_secrets to trim_baseline_of_removed_secrets
Renamed git_files to files_to_scan
Fix typo (propogate -> propagate)

When no secrets are present, that is.

(pre_commit_hook.py)
    Do not raise exception when baseline out-of-date
    Replace baseline `version`/`plugins` with the current ones.
    Replaced `raise_exception_if_baseline_version_is_outdated` with if statement
    Renamed `raise_exception_if_baseline_file_is_not_up_to_date` to `raise_exception_if_baseline_file_is_unstaged`
    Improve comment

(core/secrets_collection.py)
    Make `version` not required for baseline's any more

(tests/pre_commit_hook_test.py):
    Replaced `test_fails_if_baseline_version_is_outdated` with `test_that_baseline_gets_updated`

Clean up:
    (core/usage.py)
        Static list into a tuple
    (core/baseline.py)
        `initialize()` docstring accurate
        Renamed `update_baseline_with_removed_secrets` to `trim_baseline_of_removed_secrets`
        Renamed `git_files` to `files_to_scan`
        Fix typo (propogate -> propagate)
@KevinHock KevinHock merged commit c3eae1d into master Nov 26, 2018
@KevinHock KevinHock changed the title 🎉 [pre-commit-hook] Automatically update the baseline [pre-commit-hook] Automatically update the baseline Nov 27, 2018
@KevinHock KevinHock deleted the autoupdate_baseline branch March 21, 2019 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants