We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I use Heartbeat monitor my service . and alert by change rule.
query_key: monitor compare_key: up ignore_null: true
but the Heartbeat's up field is Boolean value 。so... https://github.com/Yelp/elastalert/blob/master/elastalert/ruletypes.py#L135
up
... def compare(self, event): key = hashable(lookup_es_key(event, self.rules['query_key'])) val = lookup_es_key(event, self.rules['compare_key']) if not val and self.rules['ignore_null']: return False ...
when the service down
up is false. not val is true and because of the ignore_null is true.
false
not val
true
ignore_null
so always return False not run compare code
return False
The text was updated successfully, but these errors were encountered:
fix change rule's bool bug
d0e7a12
fix Yelp#925
3425b9b
fix #925
Successfully merging a pull request may close this issue.
I use Heartbeat monitor my service . and alert by change rule.
but the Heartbeat's
up
field is Boolean value 。so...https://github.com/Yelp/elastalert/blob/master/elastalert/ruletypes.py#L135
when the service down
up
isfalse
.not val
istrue
and because of theignore_null
istrue
.so always
return False
not run compare codeThe text was updated successfully, but these errors were encountered: