Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docs for terms_size, upped the default, and fixed top_count_number #84

Merged
merged 2 commits into from
May 11, 2015

Conversation

Qmando
Copy link
Member

@Qmando Qmando commented May 6, 2015

This fixes #73 and #83. terms_size was undocumented and had a ridiculously low default. Also, it overrode top_count_number because the code was shared.

@ivanlei
Copy link

ivanlei commented May 11, 2015

@mlw and @Qmando let's complete the review and push this sucker.

Qmando added a commit that referenced this pull request May 11, 2015
Added docs for terms_size, upped the default, and fixed top_count_number
@Qmando Qmando merged commit 01565d3 into master May 11, 2015
@Qmando Qmando deleted the document_terms_size branch May 11, 2015 19:09
amoennin pushed a commit to amoennin/elastalert that referenced this pull request Sep 15, 2015
Added docs for terms_size, upped the default, and fixed top_count_number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

top_count_number sometimes doesn't work
3 participants