Fixes #1 #2
Merged
Fixes #1 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm having a hard time understanding how the headers are related to this timeout. The stacktrace in the issue only has the last line. Could you explain what's going on here? It seems like at the very list there is a bug in twisted or somewhere else, if an unexpected header value results in a TimeoutError. |
| for key, val in headers.iteritems(): | ||
| if not isinstance(val, list): | ||
| headers[key] = [val] | ||
| return Headers(headers) |
There was a problem hiding this comment.
This is such a bizarre interface for Headers. I have no idea why Twisted would do this.
|
Added further description of the bug in #1. |
prat0318
force-pushed
the
listify_headers
branch
from
aa3bc3c
to
37e1bd9
Compare
|
lgtm |
prat0318
added a commit
that referenced
this pull request
Jul 14, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used the code from swagger-py