Fido python3 ready #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucagiovagnoli
force-pushed
the
luca/fido-py3-ready
branch
from
6b31aea
to
fc4ba6a
Compare
| self.code = code | ||
| self.body = body | ||
| self.reason = reason | ||
| self._headers = dict(headers.getAllRawHeaders()) |
There was a problem hiding this comment.
Why do you need this property change for python 3 ?
There was a problem hiding this comment.
I agree: this shouldn't change
lucagiovagnoli
force-pushed
the
luca/fido-py3-ready
branch
from
4caf761
to
0c0583c
Compare
|
lg2m python3 ftw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving issues between strings and bytes. A bit of test refactoring and cleanup. Tests passing.