Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly conditional depend on futures #35

Merged
merged 1 commit into from
May 24, 2016
Merged

Correctly conditional depend on futures #35

merged 1 commit into from
May 24, 2016

Conversation

asottile
Copy link
Contributor

No description provided.

@asottile asottile closed this May 23, 2016
@asottile asottile deleted the conditional_dependencies_done_right branch May 23, 2016 17:02
@asottile asottile restored the conditional_dependencies_done_right branch May 23, 2016 17:02
@asottile asottile deleted the conditional_dependencies_done_right branch May 23, 2016 17:13
@asottile asottile restored the conditional_dependencies_done_right branch May 23, 2016 17:13
@asottile asottile reopened this May 23, 2016
@asottile
Copy link
Contributor Author

@analogue github is having issues today, I reopened this PR -- would love a review :)

@coveralls
Copy link

coveralls commented May 23, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 99.01% when pulling 235d04c on asottile:conditional_dependencies_done_right into 233ce88 on Yelp:master.

@analogue
Copy link
Contributor

lgtm

@analogue analogue merged commit 8e35827 into Yelp:master May 24, 2016
@asottile asottile deleted the conditional_dependencies_done_right branch May 24, 2016 19:17
@lucagiovagnoli
Copy link
Contributor

Fido is not using futures anymore since version 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@asottile @coveralls @analogue @lucagiovagnoli