Fix broken build #61
Merged
Fix broken build #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build of the package is broken because from April 16th, 2019 travis uses python 3.6 as default python version.
This causes:
Fixing the travis configurations I've noticed that updates on twisted dependency made the latest versions not supporting python3.3 and python3.4.
In order to fix it I've updated the setup.py file in order to define a max twisted version for the specified versions.
NOTE: In a follow-up PR I'll try to address test failures on python3.5 and python3.6 by enabling the repo to test such versions