Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove all non-pstats formats and change graph format to include milliseconds. add py.test and tox for running test. #1

Merged
merged 2 commits into from
Jan 4, 2016

Conversation

mjbryant
Copy link

@mjbryant mjbryant commented Jan 4, 2016

Pretty large change. Mostly deleting non-pstats stuff. The only substantive changes are:

  1. Better (i.e. actually runnable) tests
  2. Including milliseconds in graph nodes
  3. General cleanup in the main function to make future changes a bit easier.

milliseconds. add py.test and tox for running test.
@@ -1,20 +1,11 @@
# About _gprof2dot_

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment with a reference to the original project here? Something like "this is a fork of [link to original] tailored to Yelp's need.

@ArnaudBrousseau
Copy link

Looking good otherwise, that's a lot less code to maintain! We can add support for whatever format we need afterwards, for now, pstats is all we need.

ArnaudBrousseau added a commit that referenced this pull request Jan 4, 2016
remove all non-pstats formats and change graph format to include milliseconds. add py.test and tox for running test.
@ArnaudBrousseau ArnaudBrousseau merged commit 6149a63 into master Jan 4, 2016
@mjbryant mjbryant deleted the mbryant-pstats-only branch January 4, 2016 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants