-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Python3 Version #69
Closed
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c1d90b5
python 3 configuration for GAE
koskorya c4f7591
updated models with new gcloud library
koskorya cb24291
updating logic files
koskorya 625bba1
util files upgraded
koskorya 26ae6f2
upgraded views
koskorya 6214ae9
final files upgraded
koskorya 34937c0
final bug fixes for functionality
koskorya cef7485
Changes based on PR review feedback
koskorya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,58 +1,30 @@ | ||
application: yelplove | ||
service: default | ||
version: 1-0-0 | ||
runtime: python27 | ||
api_version: 1 | ||
threadsafe: true | ||
runtime: python37 | ||
instance_class: F2 | ||
|
||
handlers: | ||
- url: /api/.* | ||
script: main.app | ||
secure: always | ||
- url: /keys/?.* | ||
script: main.app | ||
login: admin | ||
secure: always | ||
- url: /subscriptions/?.* | ||
script: main.app | ||
login: admin | ||
secure: always | ||
- url: /aliases/?.* | ||
script: main.app | ||
login: admin | ||
secure: always | ||
- url: /robots.txt | ||
static_files: static/robots.txt | ||
upload: static/robots.txt | ||
secure: optional | ||
- url: /static | ||
static_dir: static | ||
secure: always | ||
- url: /_themes/(.*)/img/(.*) | ||
static_files: themes/\1/static/img/\2 | ||
upload: themes/(.*)/static/img/(.*) | ||
secure: always | ||
login: optional | ||
- url: .* # Anything not explicitly listed above | ||
script: main.app | ||
login: required | ||
secure: always | ||
|
||
builtins: | ||
- remote_api: on | ||
|
||
libraries: | ||
- name: ssl | ||
version: latest | ||
|
||
skip_files: | ||
- ^(.*/)?#.*#$ | ||
- ^(.*/)?.*/RCS/.*$ | ||
- ^(.*/)?.*\.py[co]$ | ||
- ^(.*/)?.*~$ | ||
- ^(.*/)?\..*$ | ||
- ^YelpLove.egg-info(/.*)?$ | ||
- ^config-example.py$ | ||
- ^google_appengine(/.*)?$ | ||
- ^tmp(/.*)?$ | ||
- ^virtualenv_.*$ | ||
- url: /api/.* | ||
script: auto | ||
secure: always | ||
- url: /keys/?.* | ||
script: auto | ||
secure: always | ||
- url: /subscriptions/?.* | ||
script: auto | ||
secure: always | ||
- url: /aliases/?.* | ||
script: auto | ||
secure: always | ||
- url: /robots.txt | ||
static_files: static/robots.txt | ||
upload: static/robots.txt | ||
secure: optional | ||
- url: /static | ||
static_dir: static | ||
secure: always | ||
- url: /_themes/(.*)/img/(.*) | ||
static_files: themes/\1/static/img/\2 | ||
upload: themes/(.*)/static/img/(.*) | ||
secure: always | ||
- url: .* # Anything not explicitly listed above | ||
script: auto | ||
secure: always |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very neat, I didn't know about this! This ndb library is not mentioned at all in the datastore migration documentation. Apparently it uses Cloud Firestore internally. Have you thought about how we're going to transfer the data? Or would we start with a new, fresh datastore?
Otherwise we could try out python-ndb, which should allow us to access the data we're currently using.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may be wrong but it appears the
python-ndb
is the same asgoogle-cloud-ndb
. The docs actually show to pip installgoogle-cloud-ndb
here.Also I believe google migrated all legacy datastore db's to use firestore in datastore mode. Shootie was upgraded using the same libraries so we wouldn't need to transfer any data and will still use the same datastore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! That's perfect then!