Revert "Set visible_to_all_users to True by default."

This reverts commit d04f57c.
Yelp · Mar 17, 2015 · 3437b70 · 3437b70
1 parent 2110910
commit 3437b70
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/docs/guides/emr-opts.rst b/docs/guides/emr-opts.rst
@@ -205,7 +205,7 @@ Job flow creation and configuration
     :switch: --visible-to-all-users
     :type: boolean
     :set: emr
-    :default: ``True``
+    :default: ``False``
 
     If ``True``, EMR job flows will be visible to all IAM users. If ``False``,
     the job flow will only be visible to the IAM user that created it. This parameter

diff --git a/mrjob/options.py b/mrjob/options.py
@@ -581,7 +581,7 @@ def add_emr_opts(opt_group):
 
         opt_group.add_option(
             '--visible-to-all-users', dest='visible_to_all_users',
-            default=True, action='store_true',
+            default=None, action='store_true',
             help='Whether the job flow is visible to all IAM users of the AWS'
                  ' account associated with the job flow. If this value is set'
                  ' to True, all IAM users of that AWS account can view and'

diff --git a/tests/test_emr.py b/tests/test_emr.py
@@ -587,17 +587,12 @@ class VisibleToAllUsersTestCase(MockEMRAndS3TestCase):
 
     def test_defaults(self):
         job_flow = self.run_and_get_job_flow()
-        self.assertEqual(job_flow.visibletoallusers, 'true')
+        self.assertEqual(job_flow.visibletoallusers, 'false')
 
     def test_visible(self):
         job_flow = self.run_and_get_job_flow('--visible-to-all-users')
         self.assertTrue(job_flow.visibletoallusers, 'true')
 
-    def test_explicit_invisible(self):
-        job_flow = self.run_and_get_job_flow('--emr-api-param', 'VisibleToAllUsers=false')
-        self.assertTrue(job_flow.visibletoallusers, 'false')
-
-
 
 class IAMJobFlowRoleTestCase(MockEMRAndS3TestCase):