Skip to content

Commit

Permalink
use "options" rather than "opts" to refer to switches
Browse files Browse the repository at this point in the history
  • Loading branch information
David Marin committed Oct 11, 2016
1 parent dc8b26c commit bfa7290
Show file tree
Hide file tree
Showing 9 changed files with 20 additions and 20 deletions.
8 changes: 4 additions & 4 deletions mrjob/launch.py
Expand Up @@ -25,8 +25,8 @@
from optparse import OptionParser

from mrjob.conf import combine_dicts
from mrjob.options import _add_basic_opts
from mrjob.options import _add_job_opts
from mrjob.options import _add_basic_options
from mrjob.options import _add_job_options
from mrjob.options import _add_runner_options
from mrjob.options import _allowed_keys
from mrjob.options import _alphabetize_options
Expand Down Expand Up @@ -291,8 +291,8 @@ def configure_options(self):
self.option_parser, 'Running the entire job')
self.option_parser.add_option_group(self.runner_opt_group)

_add_basic_opts(self.runner_opt_group)
_add_job_opts(self.runner_opt_group)
_add_basic_options(self.runner_opt_group)
_add_job_options(self.runner_opt_group)
_add_runner_options(
self.runner_opt_group,
_pick_runner_opts('base') - set(['strict_protocols']))
Expand Down
4 changes: 2 additions & 2 deletions mrjob/options.py
Expand Up @@ -1299,7 +1299,7 @@ def _add_runner_options_for_opt(parser, opt_name, include_deprecated=True):

### non-runner switches ###

def _add_basic_opts(opt_group):
def _add_basic_options(opt_group):
"""Options for all command line tools"""

opt_group.add_option(
Expand All @@ -1322,7 +1322,7 @@ def _add_basic_opts(opt_group):
action='store_true', help='print more messages to stderr')


def _add_job_opts(opt_group):
def _add_job_options(opt_group):
opt_group.add_option(
'--no-output', dest='no_output',
default=None, action='store_true',
Expand Down
4 changes: 2 additions & 2 deletions mrjob/tools/emr/audit_usage.py
Expand Up @@ -60,7 +60,7 @@
from mrjob.emr import _yield_all_clusters
from mrjob.emr import _yield_all_bootstrap_actions
from mrjob.job import MRJob
from mrjob.options import _add_basic_opts
from mrjob.options import _add_basic_options
from mrjob.options import _add_runner_options
from mrjob.options import _alphabetize_options
from mrjob.options import _pick_runner_opts
Expand Down Expand Up @@ -114,7 +114,7 @@ def _make_option_parser():
help=('Max number of days ago to look at jobs. By default, we go back'
' as far as EMR supports (currently about 2 months)'))

_add_basic_opts(option_parser)
_add_basic_options(option_parser)
_add_runner_options(
option_parser,
_pick_runner_opts('emr', 'connect'))
Expand Down
4 changes: 2 additions & 2 deletions mrjob/tools/emr/create_cluster.py
Expand Up @@ -241,7 +241,7 @@

from mrjob.emr import EMRJobRunner
from mrjob.job import MRJob
from mrjob.options import _add_basic_opts
from mrjob.options import _add_basic_options
from mrjob.options import _add_runner_options
from mrjob.options import _alphabetize_options
from mrjob.options import _pick_runner_opts
Expand Down Expand Up @@ -286,7 +286,7 @@ def _make_option_parser():
' crontab; clusters left idle can quickly become expensive!')
option_parser = OptionParser(usage=usage, description=description)

_add_basic_opts(option_parser)
_add_basic_options(option_parser)
_add_runner_options(
option_parser,
(_pick_runner_opts('emr', 'connect') |
Expand Down
4 changes: 2 additions & 2 deletions mrjob/tools/emr/mrboss.py
Expand Up @@ -53,7 +53,7 @@

from mrjob.emr import EMRJobRunner
from mrjob.job import MRJob
from mrjob.options import _add_basic_opts
from mrjob.options import _add_basic_options
from mrjob.options import _add_runner_options
from mrjob.options import _alphabetize_options
from mrjob.options import _pick_runner_opts
Expand All @@ -75,7 +75,7 @@ def main(cl_args=None):
default=None,
help="Specify an output directory (default:"
" CLUSTER_ID)")
_add_basic_opts(option_parser)
_add_basic_options(option_parser)
_add_runner_options(
option_parser,
_pick_runner_opts('emr', 'connect') | set(
Expand Down
4 changes: 2 additions & 2 deletions mrjob/tools/emr/report_long_jobs.py
Expand Up @@ -55,7 +55,7 @@
from mrjob.emr import _list_all_steps
from mrjob.emr import _yield_all_clusters
from mrjob.job import MRJob
from mrjob.options import _add_basic_opts
from mrjob.options import _add_basic_options
from mrjob.options import _add_runner_options
from mrjob.options import _alphabetize_options
from mrjob.options import _pick_runner_opts
Expand Down Expand Up @@ -231,7 +231,7 @@ def _make_option_parser():
help=('Minimum number of hours a job can run before we report it.'
' Default: %default'))

_add_basic_opts(option_parser)
_add_basic_options(option_parser)
_add_runner_options(
option_parser,
_pick_runner_opts('emr', 'connect')
Expand Down
4 changes: 2 additions & 2 deletions mrjob/tools/emr/s3_tmpwatch.py
Expand Up @@ -53,7 +53,7 @@
from mrjob.emr import EMRJobRunner
from mrjob.emr import iso8601_to_datetime
from mrjob.job import MRJob
from mrjob.options import _add_basic_opts
from mrjob.options import _add_basic_options
from mrjob.options import _add_runner_options
from mrjob.options import _alphabetize_options
from mrjob.parse import parse_s3_uri
Expand Down Expand Up @@ -143,7 +143,7 @@ def _make_option_parser():
action='store_true',
help="Don't actually delete any files; just log that we would")

_add_basic_opts(option_parser)
_add_basic_options(option_parser)
_add_runner_options(
option_parser,
set(['region', 's3_endpoint']),
Expand Down
4 changes: 2 additions & 2 deletions mrjob/tools/emr/terminate_cluster.py
Expand Up @@ -48,7 +48,7 @@

from mrjob.emr import EMRJobRunner
from mrjob.job import MRJob
from mrjob.options import _add_basic_opts
from mrjob.options import _add_basic_options
from mrjob.options import _add_runner_options
from mrjob.options import _alphabetize_options
from mrjob.options import _pick_runner_opts
Expand Down Expand Up @@ -85,7 +85,7 @@ def _make_option_parser():
action='store_true',
help="Don't actually delete any files; just log that we would")

_add_basic_opts(option_parser)
_add_basic_options(option_parser)
_add_runner_options(
option_parser,
_pick_runner_opts('emr', 'connect'))
Expand Down
4 changes: 2 additions & 2 deletions mrjob/tools/emr/terminate_idle_clusters.py
Expand Up @@ -75,7 +75,7 @@
from mrjob.emr import _yield_all_bootstrap_actions
from mrjob.emr import _yield_all_clusters
from mrjob.job import MRJob
from mrjob.options import _add_basic_opts
from mrjob.options import _add_basic_options
from mrjob.options import _add_runner_options
from mrjob.options import _alphabetize_options
from mrjob.options import _pick_runner_opts
Expand Down Expand Up @@ -415,7 +415,7 @@ def _make_option_parser():
action='store_true',
help="Don't actually kill idle jobs; just log that we would")

_add_basic_opts(option_parser)
_add_basic_options(option_parser)
_add_runner_options(
option_parser,
_pick_runner_opts('emr', 'connect'))
Expand Down

0 comments on commit bfa7290

Please sign in to comment.