Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clusters, not job flows #1082

Closed
coyotemarin opened this issue Jul 14, 2015 · 2 comments · Fixed by #1226
Closed

clusters, not job flows #1082

coyotemarin opened this issue Jul 14, 2015 · 2 comments · Fixed by #1226
Labels
Cleanup
Milestone
v0.5.0

Comments

@coyotemarin
Copy link
Collaborator

Issue #876 replaces references to "job flows" with "clusters" internally, but leaves exposed methods, logging messages, etc. as-is.

We should use "cluster" wherever we currently use "job flow". The old names should still work until v0.6.0.
@coyotemarin coyotemarin added this to the v0.5.0 milestone Jul 14, 2015
alejandro-rivera added a commit to alejandro-rivera/mrjob that referenced this issue Jul 15, 2015
@alejandro-rivera
Improve the documentation for the emr_tags option. It reads better no…
1fbf38b 
…w. It also complies with Yelp#1082.
@alejandro-rivera alejandro-rivera mentioned this issue Jul 15, 2015
Merged
This was referenced Jul 24, 2015
Merged
Closed
@coyotemarin coyotemarin modified the milestones: v0.5.0: Code Complete, v0.5.0: Final Cleanup Nov 25, 2015
@coyotemarin coyotemarin modified the milestones: v0.5.0: Final Cleanup, v0.5.0 Jan 15, 2016
@coyotemarin
Copy link
Collaborator Author

Places where we still need to use "job flow" in the code:

  • boto's add_jobflow_steps(), run_jobflow() and terminate_jobflow() (the API calls haven't even been renamed)
  • JobFlowRole param to RunJobFlow

@coyotemarin
Copy link
Collaborator Author

Ack, even the JOB_FLOW runner cleanup option needs to be renamed.

@coyotemarin coyotemarin mentioned this issue Feb 21, 2016
Merged
coyotemarin pushed a commit that referenced this issue Feb 21, 2016
Merge pull request #1226 from davidmarin/cluster-not-job-flow
4d4382c 
Use "cluster" in place of "job flow". Fixes #1082.
@coyotemarin coyotemarin mentioned this issue Mar 25, 2016
Closed
46 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Cleanup
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging a pull request may close this issue.

cluster, not job flow coyotemarin/mrjob
1 participant
@coyotemarin