You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
MRJob.*_PROTOCOL is supposed to be set to a class, but our code just treats it as a callable, which makes it possible to define e.g. INPUT_PROTOCOL as a method (which is what input_protocol() is for).
This seems somewhat harmless, but I don't want people to get into this habit and have to support it later.
I also briefly considered merging INPUT_PROTOCOL and input_protocol (since as of v0.4 they have identical functionality), but it messes up the consistency with other constants (e.g. HADOOP_INPUT_FORMAT).
The text was updated successfully, but these errors were encountered:
MRJob.*_PROTOCOL
is supposed to be set to a class, but our code just treats it as a callable, which makes it possible to define e.g.INPUT_PROTOCOL
as a method (which is whatinput_protocol()
is for).This seems somewhat harmless, but I don't want people to get into this habit and have to support it later.
I also briefly considered merging
INPUT_PROTOCOL
andinput_protocol
(since as of v0.4 they have identical functionality), but it messes up the consistency with other constants (e.g.HADOOP_INPUT_FORMAT
).The text was updated successfully, but these errors were encountered: