Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn when *_PROTOCOL is a non-class #490

Closed
coyotemarin opened this issue Jun 25, 2012 · 0 comments
Closed

warn when *_PROTOCOL is a non-class #490

coyotemarin opened this issue Jun 25, 2012 · 0 comments
Labels
Milestone

Comments

@coyotemarin
Copy link
Collaborator

MRJob.*_PROTOCOL is supposed to be set to a class, but our code just treats it as a callable, which makes it possible to define e.g. INPUT_PROTOCOL as a method (which is what input_protocol() is for).

This seems somewhat harmless, but I don't want people to get into this habit and have to support it later.

I also briefly considered merging INPUT_PROTOCOL and input_protocol (since as of v0.4 they have identical functionality), but it messes up the consistency with other constants (e.g. HADOOP_INPUT_FORMAT).

@irskep irskep closed this as completed in 73817c5 Jun 28, 2012
irskep pushed a commit to irskep/mrjob that referenced this issue Jul 3, 2012
@ghost ghost assigned irskep Jul 16, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants