Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix setup.py and tests so that Python 3.4 and 3.8 work #2152

Merged
merged 11 commits into from
Mar 27, 2020

Conversation

coyotemarin
Copy link
Collaborator

Python 3.4 needs to not install the latest version of PyYAML (3.4 has reached end-of-life; we're only keeping it around to support old AMIs)

pyspark doesn't currently support Python 3.8, so we need to not install it when testing, and we need to properly skip all the tests that depend on pyspark.

setup.py Outdated Show resolved Hide resolved
@88manpreet
Copy link
Contributor

+1

@coyotemarin coyotemarin merged commit 002ebd1 into Yelp:master Mar 27, 2020
@coyotemarin coyotemarin deleted the python-3.4-setup branch March 27, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants