Skip to content
This repository has been archived by the owner on Oct 5, 2019. It is now read-only.

Travis config file #41

Merged
merged 4 commits into from
Dec 30, 2014
Merged

Travis config file #41

merged 4 commits into from
Dec 30, 2014

Conversation

tomelm
Copy link
Contributor

@tomelm tomelm commented Dec 29, 2014

This adds Travis CI configs for testing

@tomelm
Copy link
Contributor Author

tomelm commented Dec 30, 2014

The test suite is running on CI now, but there are some test failures. I looked through the traceback but since I don't have a complete understanding of what's going on I can't really diagnose if this is a config failure.

It looks like all of the failures are similar:

ERROR in 0.00s
tests.output_filters.find_domains_test FindDomainsFilterTest.test_info_domain ... error: tests.output_filters.find_domains_test FindDomainsFilterTest.test_info_domain
Traceback (most recent call last):
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/contextlib.py", line 17, in __enter__
    return self.gen.next()
  File "/Users/travis/build/Yelp/osxcollector/.tox/py/lib/python2.7/site-packages/testify/test_fixtures.py", line 73, in wrapper
    fixture()
  File "tests/output_filters/find_domains_test.py", line 12, in setup_inputs
    self._output_filter = FindDomainsFilter()
  File "osxcollector/output_filters/find_domains.py", line 27, in __init__
    super(FindDomainsFilter, self).__init__()
  File "osxcollector/output_filters/base_filters/output_filter.py", line 24, in __init__
    self.config = Config(self.__class__.__name__)
  File "osxcollector/output_filters/base_filters/output_filter.py", line 66, in __init__
    with open(os.path.join(loc, 'osxcollector.yaml')) as source:
  File "/Users/travis/build/Yelp/osxcollector/.tox/py/lib/python2.7/posixpath.py", line 77, in join
    elif path == '' or path.endswith('/'):
AttributeError: 'NoneType' object has no attribute 'endswith'

@ivanlei or anyone else, can you check? The build is also if you want to see the entire output: https://travis-ci.org/Yelp/osxcollector/builds/45476244

@ivanlei
Copy link

ivanlei commented Dec 30, 2014

I'm guessing this is what happens when tests are run without a valid config file. Tests shouldn't need a config file. This seems like a bug.

@tomelm
Copy link
Contributor Author

tomelm commented Dec 30, 2014

This should also fix #43 now

ivanlei pushed a commit that referenced this pull request Dec 30, 2014
@ivanlei ivanlei merged commit ca9b16d into master Dec 30, 2014
@ivanlei
Copy link

ivanlei commented Dec 30, 2014

This is so awesome. @tomelm you rule!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants