Handle when zipkin_attrs are passed in and sampled correctly #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d, but the zipkin_span also has a sample_rate argument
kaisen
reviewed
Sep 30, 2016
| if self.sample_rate is not None: | ||
| self.is_root = True | ||
|
|
||
| # This clause allows for sampling this service independently |
There was a problem hiding this comment.
just to clarify for my own understanding, this means that sample_rate is the sampling rate of all requests that are not already sampled by a parent caller? so the actual tracing rate of the service is potentially higher than the specified sample_rate.
There was a problem hiding this comment.
if so i think it'll be worth mentioning this in the docstring for the sample_rate param
There was a problem hiding this comment.
Yes, this is true, but it was true before this PR. I will update the docs.
There was a problem hiding this comment.
oh yeah 😣 thanks for adding documentation that i should have added! 😅
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sampled zipkin_attrs are passed into
zipkin_spanalong with a sample_rate param, new zipkin_attrs are generated, even when they shouldn't be. This fixes that.I also renamed the 'is_root' to 'perform_logging' and moved the logic around a bit. I can't recall if we've discussed this before, but I still find the 'is_root' variable name to be confusing. I'm open to changing that part back if anyone feels strongly.
Finally, added a regression test for the correct zipkin_attrs + sampling logic.