Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor encodings into their own folder. #105

Merged
merged 1 commit into from
Oct 19, 2018

Conversation

drolando
Copy link
Contributor

This will better split out the logic and make it easier to add decoders
in #100

The logic is the same, I just split _encoding_helpers in 2 different files and put them under encoding/
I also had to move some definitions to encoding/_types.py to avoid circular imports.

Existing tests still pass and coverage is still at 100%

This will better split out the logic and make it easier to add decoders
in Yelp#100
@drolando drolando requested a review from wvivar October 18, 2018 23:32
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1624181 on drolando:refactor_encoding_in_its_own_folder into 9090269 on Yelp:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1624181 on drolando:refactor_encoding_in_its_own_folder into 9090269 on Yelp:master.

@drolando drolando merged commit 2f18c3f into Yelp:master Oct 19, 2018
@drolando drolando deleted the refactor_encoding_in_its_own_folder branch October 25, 2018 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants