Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base path to operation path name #1

Merged

Conversation

TamasFlorin
Copy link

When a service has a 'basePath' defined the mock_server will not find the corresponding mocks due to the fact that it does not take into account the 'basePath'.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling af4697c on TamasFlorin:add-base-path-to-swagger-resource into d630265 on Yelp:master.

Copy link
Contributor

@macisamuele macisamuele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me.

@macisamuele macisamuele merged commit 20a2614 into Yelp:master Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants