Feature: exclude routes from validation #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This branch needs the test fix from #82 |
| @@ -39,6 +39,9 @@ A few relevant settings for your `Pyramid .ini file <http://docs.pylonsproject.o | |||
| # Default: [r'^/static/?', r'^/api-docs/?'] | |||
| pyramid_swagger.exclude_paths = [r'^/static/?', r'^/api-docs/?'] | |||
|
|
|||
| # Exclude routes from validation. Accepts a list of strings | |||
There was a problem hiding this comment.
"exclude pyramid routes"? Not sure if this needs clarification...
There was a problem hiding this comment.
Doesn't hurt to be explicit about it, will update
|
No major issues. I'll re-review once comments + merging w/ #82 are done |
dnephin
force-pushed
the
exclude_route_off_master
branch
from
9194e01
to
6076575
Compare
Conflicts: tests/tween_test.py
dnephin
force-pushed
the
exclude_route_off_master
branch
from
6076575
to
dbdb969
Compare
striglia
added a commit
that referenced
this pull request
Feb 26, 2015
Feature: exclude routes from validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently requests can be excluded by path, or by disabling all path validation.
This PR adds support for excluding some routes from validation as another option before disabling all path validation.
y-m uses a single fallback route for legacy routing, so this will allow us to use path validation for all pyramid views, and exclude legacy views.