Fix tests and add encoding support #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
py-zipkin now supports multiple encodings. This change adds a new optional argument that lets you choose which encoding you want to use. It defaults to V1_THRIFT to maintain backward-compatibility.
Tests depend on thriftpy but don't define it as a dependency, relying on py-zipkin to install it. Since 0.17 py-zipkin has moved to thriftpy2 and that broke our tests. Rather than moving to thriftpy2 I changed the tests to use python since it simplifies the logic quite a bit.
acer618
approved these changes
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests depend on thriftpy but don't define it as a dependency, relying on
py-zipkin to install it. Since 0.17 py-zipkin has moved to thriftpy2
and that broke our tests.
Rather than moving to thriftpy2 I changed the tests to use python since
it simplifies the logic quite a bit.