set response status code in zipkin spans during exceptions #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acer618
changed the title
dmfallak
requested changes
Oct 6, 2023
dmfallak
approved these changes
Oct 6, 2023
EOjeah
reviewed
Oct 9, 2023
pyramid_zipkin/tween.py
Outdated
| response = handler(request) | ||
| except Exception as e: | ||
| zipkin_context.update_binary_annotations({ | ||
| 'error_type': type(e).__name__, |
There was a problem hiding this comment.
to ease any future efforts on adapting to opentelemetry's semantic conventions can we use error.type as the annotation instead?
Source -> http-spans
There was a problem hiding this comment.
good call out! made the change
jvperrin
approved these changes
Oct 9, 2023
yalinglee
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When request processing has exceptions, the zipkin tween will now catch this exception (and re-raise it). Handling this exception in the zipkin tween lets us set the response_status_code (and error_type). This will be useful as SERVER side spans are using for analysis
Tested:
Code change to simulate the error: https://fluffy.yelpcorp.com/i/BrBMl9576HPCwvJBwPHsD4N6Gw5g8RSw.html
Test endpoint: https://www.amokal-example-happyhour-uwsgi.dev.yelp.com/hours/1234567890/v1?zipkin_email=amokal@yelp.com
Trace: https://fluffy.yelpcorp.com/i/1mFnjTRXmFhMWPz3sSWfnmTVD8Dq6lXx.html