Disable decommission for non-spot pools #119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you need to pull master and resolve conflicts. I'll review again |
nemacysts
reviewed
Aug 1, 2023
88manpreet
force-pushed
the
d/manpreet/MLCOMPUTE-744_disable_decommission_non_batch_pools
branch
from
9407cd1
to
156ab0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decommission feature makes sense only for spot pools.
There have been issues seen in the past for on-demand pools where the spark executors were running for long-time even if there are no active tasks, leading to hanging jobs
This has potentially been linked to decommission feature.
There shouldn't be any downside of disabling this feature for non-spot pools.