Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default user name label #140

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Fix default user name label #140

merged 1 commit into from
Feb 21, 2024

Conversation

edingroot
Copy link
Contributor

For addressing the following pod creation error when the USER environment variable is not set.

metadata.labels: Invalid value: "_unspecified_": a valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue',  or 'my_value',  or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?')

edingroot
edingroot commented Feb 21, 2024
View reviewed changes
service_configuration_lib/spark_config.py
@@ -270,14 +270,16 @@ def _get_k8s_spark_env(
service_account_name: Optional[str] = None,
include_self_managed_configs: bool = True,
k8s_server_address: Optional[str] = None,
user: Optional[str] = None,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provide an interface for paasta tron_tools to specify user name for spark driver on k8s.

@edingroot edingroot merged commit 56464b6 into master Feb 21, 2024
1 check passed
@edingroot edingroot deleted the u/chi/fix_default_user_tag branch February 21, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@88manpreet 88manpreet 88manpreet approved these changes

@austinzh austinzh austinzh approved these changes

@CaptainSame CaptainSame Awaiting requested review from CaptainSame

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@edingroot @88manpreet @austinzh @chi-yelp