MLCOMPUTE-967 | Spark config calculation should result in failure if srv-configs can't be read #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…srv-configs can't be read
nemacysts
reviewed
Feb 27, 2024
| @@ -397,6 +395,8 @@ def __init__(self): | |||
| ) = utils.load_spark_srv_conf() | |||
| except Exception as e: | |||
| log.error(f'Failed to load Spark srv configs: {e}') | |||
| # should fail because Spark config calculation depends on values in srv-configs | |||
| sys.exit(1) | |||
There was a problem hiding this comment.
might be a little cleaner to throw an exception - sys.exit() outside of something like the driver for a script can be a little unexpected
88manpreet
reviewed
Feb 27, 2024
| ), | ||
| ) | ||
| except Exception: | ||
| ui_port = utils.ephemeral_port_reserve_range() |
There was a problem hiding this comment.
Add a warning log stating the error and back-up option.
edingroot
approved these changes
Feb 28, 2024
88manpreet
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no_aws_credentialsarg fromget_aws_credentialsfunction