Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAPI 3.0 compatibility #51

Open
giolaq opened this issue Jul 23, 2019 · 18 comments
Open

OpenAPI 3.0 compatibility #51

giolaq opened this issue Jul 23, 2019 · 18 comments
Assignees
Labels
help wanted Extra attention is needed
Milestone

Comments

@giolaq
Copy link

giolaq commented Jul 23, 2019

It could be a good thing if the builder could parse OpenAPI 3.0 swagger json file

https://swagger.io/docs/specification/about/

@cortinico cortinico added the help wanted Extra attention is needed label Jul 24, 2019
@cortinico
Copy link
Collaborator

cortinico commented Jul 24, 2019

It could be a good thing if the builder could parse OpenAPI 3.0 swagger json file

Hey @joaobiriba
Thanks for the request. Ideally we should bump the Swagger Codegen version we are using to 3.x.
Unfortunately this introduces a lot of breaking changes with the current KotlinGenerator class. (ping @macisamuele )

So ideally is something that will be implemented but not in the near future.
We're welcoming external contributors anyway :)

@giolaq
Copy link
Author

giolaq commented Jul 24, 2019

Ok, let's see if I can found some time to work on it. This helped me to save some time, I could give back :)

@hybras
Copy link

hybras commented Mar 17, 2020

So at this time the plugin does not support OpenAPI 3? Or is it json specifically?
EDIT: Thanks @cortinico for swift reply

@cortinico
Copy link
Collaborator

So at this time the plugin does not support OpenAPI 3? Or is it json specifically?

Correct, at this time the plugin doesn't support OpenAPI 3. We might achieve this by bumping the swagger-codegen dependency to 3.x but we still have to investigate the amount of work needed.

@stephen-mojo
Copy link

It has been a while since the last comment on this thread. Has any work been done to bump Swagger Codegen to OpenAPI 3.0? Thanks.

@cortinico
Copy link
Collaborator

Has any work been done to bump Swagger Codegen to OpenAPI 3.0? Thanks.

Not on my end. I'm unsure if @macisamuele did some work on that front.

@macisamuele
Copy link
Collaborator

I've looked into it long time ago (sorry for that) and seems that moving to the latest io.swagger:swagger-codegen (which supports openapi v3) might require some effort and it might interfere a bit (due to templating conflicts) with #103 .
I've sync a bit with @cortinico and we thought that I can start doing some prep work on enabling open api v3 and then afterwards dealing with eventual conflicts.

Enabling polymorphism seems being an interesting feature (at least it is for me) but we are not getting many requests on that regard, so it does not seem wise to hold openapi v3 longer

@cortinico cortinico added this to the 2.0.0 milestone Oct 26, 2020
@jmgarbowski
Copy link

Hi everyone, is there any updates for this request?

@cortinico
Copy link
Collaborator

Sadly not. I haven't got much time to work on this recently. It's free to pick-up if someone wants to contribute. Me and @macisamuele were working on the Polymorphism support, and we would like to ship it before the OpenAPI change. Other than that, there are no major updates.

@CristianMG
Copy link

Hi, We have some idea, How much effort would take to give the support on OpenApi 3.0?
I would like to use this library, but in the back-end they use OpenApi 3.0

@aggarwalpulkit596
Copy link

@cortinico I would like to work on this could you maybe layout some ground tasks so that I can start?

@mobilekosmos
Copy link

So I suppose this lib is abandoned? :/

@macisamuele
Copy link
Collaborator

Unfortunately, I'm finding myself very short in free available time to actually provide a timeline on when this feature will be implemented but PRs are always welcome.

One of the major caveats that I've experienced, what I've started last time trying to update io.swagger:swagger-codegen to the latest version, was around types and "making the code compile" (even if not 100% accurate).
This because the migration from V2 to V3 requires a non-trivial code refactor (and I was just not ready to commit to it yet).

@mobilekosmos
Copy link

Why is this proyect only a free time proyect, why is nobody imvesting money in the development? Or asking in another way, what are the alternatives to this? I'm new to this topic and would need to integrate a REST Api which has a openapi v3 config in a kotlin/Android proyect and I'm not knowing where to start, it seems that the swagger codegen only generates something simple if I understand it correctly and this lib would be more advanced?

@cortinico cortinico self-assigned this Oct 31, 2021
@cortinico
Copy link
Collaborator

So I suppose this lib is abandoned? :/

Just as a follow up: nope is not abandoned. We're doing on our free time that, as you can imagine, is extremely limited. Specifically I was working on this specific issue. The problem is that swagger-codegen 2.x => 3.x is introducing a significant number of API changes.

The result is that bumping this library and adding OpenAPI 3 support would require a significant amount of time.

If someone has time to look into this, and wants to send a PR, we'll be more than happy to review anyway 👍

@pischky
Copy link

pischky commented May 19, 2022

Support for openAPI v3 would really be nice ;-)

@Lizzergas
Copy link

Bumping for OpenAPI v3 support:)

@alex-dokienko
Copy link

even in 2023 still valid thing to have 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests