Fix missing inner enum import on operations #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
macisamuele
requested changes
Dec 30, 2019
There was a problem hiding this comment.
Overall the change looks good.
I would suggest a small refactor in order to make the new methods independent from Kotlin.
Something else that would be nice to check is related to inlined models into requests parameters (it might be done into a different PR as well).
PS: personally I would have replaced isMapTypeWrapped with a regex matching of the mapTypeWrapper (but not blocking)
Previously inner types of complex types were not imported properly on operations. This resulted in Retrofit interfaces missing some imports. This commit introduces methods to inspect and import the inner types used as result types of operations. Fixes Yelp#76
cortinico
force-pushed
the
fix-76-missing-inner-enum-import
branch
from
84b2b50
to
54b94dd
Compare
|
@macisamuele ready for another pass :) I've addressed all the comments.
You're more than welcome to add it once this gets merged :) |
macisamuele
approved these changes
Jan 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously inner types of complex types were not imported properly on
operations. This resulted in Retrofit interfaces missing some imports.
This commit introduces methods to inspect and import the inner types
used as result types of operations.
Fixes #76
Ping @macisamuele for the review