Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for blacklisting rules #6

Merged
merged 2 commits into from Mar 6, 2019

Conversation

macisamuele
Copy link
Collaborator

Fixes: #5

The goal of this PR is to add support for blacklisting rules via CLI parameters.
In order to achieve it we're using mutually exclusive CLI arguments, such that it would not be possible to have whitelist and blacklist defined at the same time.

Copy link

@sjaensch sjaensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally lg2m, fix tests and ship it. :)

@codecov
Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #6 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #6   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          58     58           
  Lines        1724   1728    +4     
  Branches      104    104           
=====================================
+ Hits         1724   1728    +4
Impacted Files Coverage Δ
tests/cli/run_test.py 100% <ø> (ø) ⬆️
swagger_spec_compatibility/cli/run.py 100% <100%> (ø) ⬆️
swagger_spec_compatibility/cli/common.py 100% <100%> (ø) ⬆️
swagger_spec_compatibility/cli/__init__.py 100% <100%> (ø) ⬆️
swagger_spec_compatibility/cli/explain.py 100% <100%> (ø) ⬆️
tests/cli/common_test.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45672c9...74ed5da. Read the comment docs.

@macisamuele macisamuele merged commit d66f50a into Yelp:master Mar 6, 2019
@macisamuele macisamuele deleted the maci-add-blacklist-CLI-support branch March 6, 2019 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants