Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide command-line interface #109

Closed
wants to merge 2 commits into from
Closed

Provide command-line interface #109

wants to merge 2 commits into from

Conversation

qsantos
Copy link

@qsantos qsantos commented Nov 29, 2018

Makes the following possible:

python -m swagger_spec_validator "http://petstore.swagger.io/v2/swagger.json"

@coveralls
Copy link

coveralls commented Nov 29, 2018

Coverage Status

Coverage decreased (-2.9%) to 95.522% when pulling ebceb95 on qsantos:master into 2a99f42 on Yelp:master.

Copy link
Contributor

@sjaensch sjaensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Please also check the output of the travis run and fix the issues pre-commit mentioned. You can run make install-hooks to make sure those hooks will be run when you commit code.

@@ -1,3 +1,6 @@
httpretty
mock
pytest
jsonschema
pyyaml
six
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These requirements are already listed in setup.py, no need to add them here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently, the correct way is to put a line with a single . so that pip install -r requirements-dev.txt will automatically look in setup.py as well. I've pushed a new version reflecting this.

@qsantos qsantos force-pushed the master branch 2 times, most recently from f22cae4 to 0b1cf49 Compare December 3, 2018 17:45
This makes it possible to call the script as follows:

python -m swagger_spec_validator "http://petstore.swagger.io/v2/swagger.json"
@nicktimko
Copy link

nicktimko commented May 17, 2019

See #105 which includes some basic tests, an entrypoint, documentation, and processing of the raised exception to print the message rather than dumping a traceback.

@qsantos qsantos closed this Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants