Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: use cache instead of reloading schema files #132

Merged
merged 1 commit into from
May 20, 2020
Merged

perf: use cache instead of reloading schema files #132

merged 1 commit into from
May 20, 2020

Conversation

brycedrennan
Copy link
Contributor

I botched the previous PR by deleting my fork. Apologies.

Feedback is all addressed from #131

@brycedrennan brycedrennan mentioned this pull request May 13, 2020
Closed
@coveralls
Copy link

coveralls commented May 13, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.4%) to 98.542% when pulling d899b74 on brycedrennan:perf-fixes into 1c1b573 on Yelp:master.

@brycedrennan brycedrennan force-pushed the perf-fixes branch 3 times, most recently from 6d1a4fe to 545afe8 Compare May 13, 2020 17:43
macisamuele
macisamuele requested changes May 13, 2020
View reviewed changes
Copy link
Collaborator

@macisamuele macisamuele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR.
Left a few comments (mostly asking for few tests update) and then this is ready to be merged.

swagger_spec_validator/common.py Outdated Show resolved Hide resolved
swagger_spec_validator/common.py Outdated Show resolved Hide resolved
tests/validator20/validate_spec_test.py Outdated Show resolved Hide resolved
tests/validator20/validate_spec_test.py Outdated Show resolved Hide resolved
@brycedrennan
Copy link
Contributor Author

I left a separate commit so you could see the changes, but will rebase into one commit once we're on the same page.

macisamuele
macisamuele reviewed May 14, 2020
View reviewed changes
tests/common_test.py Outdated Show resolved Hide resolved
@brycedrennan
perf: use cache instead of reloading schema files
d899b74 
functools32 was already a dependency of jsonschema so this does not add a new dependency
@brycedrennan
Copy link
Contributor Author

@macisamuele feedback addressed.

macisamuele
macisamuele approved these changes May 15, 2020
View reviewed changes
Copy link
Collaborator

@macisamuele macisamuele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks for the effort, really appreciated.

🚢

@macisamuele
Copy link
Collaborator

Considering that today is Friday (and generally is not a good idea to release when you're not around) I'll merge this on Monday and take care of releasing a new version

@macisamuele macisamuele merged commit dc03f20 into Yelp:master May 20, 2020
@macisamuele
Copy link
Collaborator

Released on 2.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macisamuele macisamuele macisamuele approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brycedrennan @coveralls @macisamuele