Added pre-commit hook and tests against python 3.5 and 3.6 #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjaensch
approved these changes
Mar 20, 2017
docs/source/conf.py
Outdated
| @@ -53,7 +54,7 @@ | |||
| source_suffix = '.rst' | |||
|
|
|||
| # The encoding of source files. | |||
| #source_encoding = 'utf-8-sig' | |||
| # source_encoding = 'utf-8-sig' | |||
There was a problem hiding this comment.
I'd recommend excluding docs/source/conf.py, the formatting changes don't really make it more readable.
| @@ -1,29 +1,28 @@ | |||
| [tox] | |||
| envlist = py27,py27-simplejson,py34 | |||
| envlist = {py27,py35,py36}-{default,simplejson},pre-commit,cover,docs | |||
There was a problem hiding this comment.
Do we really need to test all of those Python versions with simplejson? Not knowing why this was introduced, I'd rather vote for dropping it, or are there known incompatibilities in recent versions?
There was a problem hiding this comment.
I'm defining all these environments too keep tox.ini "simple". On travis, we're running tests with simplejson only for python 2.7.
macisamuele
force-pushed
the
update-requirements-tox-pre-commit
branch
from
75f2deb
to
8f804db
Compare
macisamuele
force-pushed
the
update-requirements-tox-pre-commit
branch
from
8f804db
to
4390d8a
Compare
macisamuele
force-pushed
the
update-requirements-tox-pre-commit
branch
from
4390d8a
to
7f77afc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CR introduces: