Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't clobber stacktrace, just let the AttributeError raise #3

Merged
merged 1 commit into from
Sep 26, 2016
Merged

Don't clobber stacktrace, just let the AttributeError raise #3

merged 1 commit into from
Sep 26, 2016

Conversation

asottile
Copy link
Contributor

This was hiding the underlying error in a stacktrace of ours.

The new line 67 will raise anyway if the attribute is not there. getattr unlike dict#get raises when not present.

@mjbryant
Copy link

👍 . This was cribbed from the bravado_decorators internal repo. You might want to change that, too, or this problem will probably happen again.

@mjbryant mjbryant merged commit 29c93f9 into Yelp:master Sep 26, 2016
@asottile asottile deleted the patch-1 branch September 26, 2016 23:02
@asottile
Copy link
Contributor Author

and that was copied from gluapy.factory apparently >.< where does the copypasta end?

@asottile
Copy link
Contributor Author

also an internal package it appears

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants