This repository has been archived by the owner on Apr 22, 2021. It is now read-only.
Add travis-ci support (and clean up tox) #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Will add the badge in a followup |
| flake8==2.5.0 | ||
| pytest==2.9.2 | ||
| mock==2.0.0 | ||
| pre-commit==0.7.6 | ||
| pytest-cov==2.2.0 |
There was a problem hiding this comment.
What's the difference between pytest-cov and coverage? Is there a reason to use one over the other?
There was a problem hiding this comment.
You weren't actually using pytest-cov (the pytest plugin for coverage). coverage is the official project
There was a problem hiding this comment.
(you were only depending on the side-effect of pytest-cov's install dependencies)
|
LGTM! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #13