py26 doesn't have a consistent exit code

Yelp · Dec 30, 2014 · b9ff362 · b9ff362
1 parent aceadd9
commit b9ff362
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -18,6 +18,6 @@
     hooks:
     -   id: system
         name: PyLint
-        entry: python -m pylint
+        entry: python -m pylint.__main__
         language: system
         files: \.py$
diff --git a/tests/functional/simple_test.py b/tests/functional/simple_test.py
@@ -347,7 +347,9 @@ def test_args_backward(tmpdir):
     with pytest.raises(CalledProcessError) as excinfo:
         venv_update('requirements.txt', 'myvenv')
 
-    assert excinfo.value.returncode == 1
+    # py26 doesn't have a consistent exit code:
+    #   http://bugs.python.org/issue15033
+    assert excinfo.value.returncode != 0
     _, err = excinfo.value.result
     lasterr = strip_coverage_warnings(err).rsplit('\n', 2)[-2]
     errname = 'NotADirectoryError' if PY33 else 'OSError'