This repository has been archived by the owner on May 23, 2023. It is now read-only.
Fix "Should be unreachable in pip8" caused by inconsistent use of normalization #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriskuehl
changed the title
chriskuehl
commented
Nov 9, 2017
| def normalize_name(name): | ||
| """Normalize a python package name a la PEP 503""" | ||
| # https://www.python.org/dev/peps/pep-0503/#normalized-names | ||
| return re.sub('[-_.]+', '-', name).lower() |
There was a problem hiding this comment.
stolen verbatim from distutils
asottile
approved these changes
Nov 9, 2017
| 'pypi-server', '-vvvvvv', | ||
| '-i', '127.0.0.1', | ||
| '-p', port, | ||
| # Default fallback is HTTP, which is no longer supported. |
There was a problem hiding this comment.
maybe a todo to remove this once a new enough pypiserver is released? or install pypiserver from git temporarily?
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 39 40 +1
Lines 1826 1849 +23
Branches 105 105
=====================================
+ Hits 1826 1849 +23
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #202
@asottile can you think of a better way to implement this?
I think the ideal way would be to capture the name of the installed package right after it's installed, but it doesn't appear that pip does that, and patching that + threading the resulting name all the way back to our code sounds unpleasant.
Or maybe WorkingSet already has a way to find a normalized name, but I couldn't find one.