This repository has been archived by the owner on May 23, 2023. It is now read-only.
Gets tests passing before I starting adding support for virtualenv 20+ #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaisen
approved these changes
Jan 27, 2021
analogue
commented
Jan 27, 2021
Comment on lines
-66
to
-69
| # old setuptools and old pip | ||
| ['setuptools==0.6c11', 'pip==1.4.1'], | ||
| # old setuptools and new pip | ||
| ['setuptools==0.6c11', 'pip==1.5.6'], |
There was a problem hiding this comment.
Another "fails on Python2 and not worth figuring out why" unless someone has other opinions.
|
Travis is taking forever - builds sitting around for hours waiting. Gonna see if I can knock out #235 |
TL;DR went down a rabbit hole with some weird failure (see #236 ) Abandoning for now. Back to this PR, tested locally and |
ymilki
approved these changes
Jan 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make testis green (on bionic at least).