This repository has been archived by the owner on May 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile
reviewed
Apr 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the invalid check can be greatly simplified as virtualenv 20.x doesn't do major copies of things
here's some prior art: https://github.com/pre-commit/pre-commit/blob/24d9dc7469f9b752b5c772d5cc829d95b43e0e8c/pre_commit/languages/python.py#L166-L186
This reverts commit 97e5a3f.
…nto use_virtualenv_gte_20
analogue
approved these changes
Jul 23, 2021
ymilki
approved these changes
Jul 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the attention to get all the tests passing!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
virtualenv>=20 contains a big refactor of the inner workings of virtualenv which broke venv-update. This PR accounts for the major changes and requires virtualenv>=20 moving forward.
Notable changes:
adjust_options
hook doesn't exist anymore in virtualenv, so the logic to check if an old virtualenv is valid needs to be done before virtualenv is invoked--system-site-packages
was passed to virtualenv is now done by checking for a config in the new pyenv.cfg fileFixes #231.