Allow passing trusted subnets #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriskuehl
commented
Aug 24, 2017
wsgi_mod_rpaf.py
Outdated
| @@ -23,27 +22,30 @@ def text_to_wsgi(s): | |||
| return s | |||
|
|
|||
|
|
|||
| PROXY_IPS_DIRECTIVE = 'RPAFproxy_ips ' | |||
| def from_apache_config(f, directive='RPAFproxy_ips'): | |||
There was a problem hiding this comment.
err, this should probably be changed to take a path rather than a file-like object
chriskuehl
force-pushed
the
allow-passing-trusted-subnets
branch
from
7e81337
to
7a3f678
Compare
asottile
reviewed
Aug 24, 2017
Makefile
Outdated
|
|
||
| .PHONY: tests test | ||
| tests: test | ||
| test: .venv.touch | ||
| test: |
There was a problem hiding this comment.
can probably get rid of tests: test while you're at it
asottile
approved these changes
Aug 24, 2017
| .PHONY: clean | ||
| clean: | ||
| find . -iname '*.pyc' -delete | ||
| find . -name '*.pyc' -delete |
There was a problem hiding this comment.
if you don't care about bsd, can do find -name '*.pyc' -delete
|
|
||
| ```python | ||
| import ipaddress | ||
|
|
There was a problem hiding this comment.
probably also have the from wsgi_mod_rpaf ... import here too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6