Add dependent response objects for business endpoint #4
Conversation
… add_response_objects_for_business_endpoint
…bjects_for_business_endpoint
| @@ -5,7 +5,7 @@ | |||
| // Created by David Chen on 1/8/16. | |||
| // | |||
| // | |||
| #import "YLPClient.h" | |||
| @class YLPCLient; | |||
There was a problem hiding this comment.
This is surprising to me, I'd assume that you must actually have the class imported to declare an extension to it. I'm wondering if this only works because you happen to have imported YLPClient beforehand in all cases before you import this file?
There was a problem hiding this comment.
Hm interesting. I wasn't paying much attention when I changed this over to class. Thinking about it now it is weird that this is working. Switching back to an import.
|
Hmm, not sure about the issues you were running into with the private headers, I'll check out the project sometime and look at it. |
|
Ahh sorry @d9chen, GitHub doesn't notify me when you push new commits so I had no idea this had been updated :( Will take a look soon. |
|
@SSheldon thanks. :) ❤️ |
| #import <YelpAPI/YLPDealOption.h> | ||
| #import <YelpAPI/YLPLocation.h> | ||
| #import <YelpAPI/YLPReview.h> | ||
| #import <YelpAPI/YLPUser.h> |
There was a problem hiding this comment.
Hmm, we should probably add an umbrella header at some point. That'd be one header, YelpAPI.h, which will import all these things for us.
Then, users of the pod can just do #import <YelpAPI/YelpAPI.h> without having to import each individual thing.
There was a problem hiding this comment.
I don't actually know how umbrella headers work in pods, it seems that one has already been generated but I can't actually import it.
Anyways, probably not something that needs to be fixed now.
|
Code looks perfect, ship it! Only things I was curious about is the pod organization and structure, but I think we can always tweak that later, so don't let that block you. I don't know all the answers there, haven't made many pods myself. |
…point Add dependent response objects for business endpoint
@SSheldon This PR adds in the rest of the response objects needed by YLPBusiness. I've also got the 'private_header_files' line commented out for now.
Xcode didn't seem to like that I was importing these headers in my tests which are targeted against the YelpAPI example project as opposed to the Pods project. Initially, the tests were targeted against the Pods project, but as I was git ignore the Pods/* dir the scheme and targets didn't carry through when the repo was checked out. My solution was to make my pod tests target the YelpAPI project instead, which seems to allow the scheme and target carry through when the repo is checked out.