Change all fields named id to more specific naming #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,7 +8,7 @@ def __init__(self, code, msg, response): | |||
| self.code = code | |||
| self.msg = msg | |||
|
|
|||
| self.id = response['error']['id'] | |||
| self.error_id = response['error']['id'] | |||
There was a problem hiding this comment.
I don't have any objection to self.id or business.id, or dictionaries with key id.
I was just complaining about variables or plain functions named id, which shadow the built-in function.
I'm fine with leaving this line the way it is.
dinahshi
force-pushed
the
dinah/rename-id-to-more-specific
branch
from
03232e1
to
d1ab66b
Compare
| @@ -2,3 +2,4 @@ httplib2==0.9.2 | |||
| oauth2==1.9.0.post1 | |||
| pre-commit==0.6.0 | |||
| pytest==2.8.1 | |||
| vcrpy==1.7.4 | |||
There was a problem hiding this comment.
Changed branches a little too quickly, ignore this line! Will remove in next commit.
|
Toned down the |
|
Much better. Here's a squirrel with a fancy hat: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @mittonk pointed out in #8 (comment),
idis a built-in function in Python so we should parseidresponse fields to more specific field names such asbusiness_id.