Make search list last in lookup #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please hold off on merging this. I'd like to get our codebase working with it first. |
asottile
force-pushed
the
search_list_last
branch
3 times, most recently
from
79cc7e2
to
c8a0545
Compare
asottile
force-pushed
the
search_list_last
branch
from
c8a0545
to
39c2726
Compare
| @@ -48,6 +49,9 @@ | |||
|
|
|||
| DEFAULT_COMPILER_SETTINGS = dict((v[0], v[1]) for v in _DEFAULT_COMPILER_SETTINGS) | |||
|
|
|||
| CLASS_NAME = '__yelp_cheetah_template_cls__' | |||
There was a problem hiding this comment.
I know it seems like bikeshed, but double-double-under has a meaning in python that's not meant here. The name mangling pattern, which is essentially what you want here is _{prefixname}__{name}. I'd be happy if we followed that convention.
…o conflict with the namespace
asottile
force-pushed
the
search_list_last
branch
from
39c2726
to
f193df0
Compare
|
I've changed the name to |
asottile
added a commit
that referenced
this pull request
Dec 18, 2014
Make search list last in lookup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.