Changelog update for major bump

CHANGELOG.md

@@ -1,4 +1,24 @@
 This changelog only guarantees backward incompatible changes will be listed.
+# v5.0.0 (2016-09-09)
+## backward incompatible changes
+- `yelp_kafka.discovery` methods using kafka discovery service instead of files
+- `yelp_kafka.discovery` methods have different names and take different parameters. An additional
+  client_id is often needed. This affects:
+  - get_all_clusters
+  - get_kafka_connection (client_id is now mandatory)
+  - get_all_kafka_connections (client_id is now mandatory)
+- Deprecated `yelp_kafka.discovery` methods deleted. These are
+  - get_local_cluster
+  - get_cluster_by_name
+  - get_local_scribe_topic
+  - get_scribe_topics
+  - get_all_local_scribe_topics
+  - get_scribe_topic_in_datacenter
+  - scribe_topic_exists_in_datacenter
+  - search_local_scribe_topics_by_regex
+  - search_local_topics_by_regex
+  - local_scribe_topic_exists
+  - get_all_consumer_config
 
 # v4.0.0 (2015-08-24)
 ## backward incompatible changes

tests/test_discovery.py

@@ -381,19 +381,19 @@ def test_get_superregion_logs_regex_invalid(
 
 @mock.patch("yelp_kafka.discovery.get_kafka_cluster", autospec=True)
 def test_get_all_clusters(
-    get_clusters,
+    get_cluster,
     mock_kafka_discovery_client,
     mock_clusters,
 ):
-    get_clusters.return_value = mock_clusters[0]
+    get_cluster.side_effect = mock_clusters
     mock_kafka_discovery_client.return_value.v1.getClustersAll.return_value. \
         result.return_value = ["test_cluster", "test_cluster_2"]
-    clusters = discovery.get_all_clusters("mycluster", "client-id")
-    assert get_clusters.call_args_list == [
-        mock.call("mycluster", "client-id", "test_cluster"),
-        mock.call("mycluster", "client-id", "test_cluster_2"),
+    clusters = discovery.get_all_clusters("mycluster_type", "client-id")
+    assert get_cluster.call_args_list == [
+        mock.call("mycluster_type", "client-id", "test_cluster"),
+        mock.call("mycluster_type", "client-id", "test_cluster_2"),
     ]
-    assert clusters == [mock_clusters[0], mock_clusters[0]]
+    assert clusters == mock_clusters
 
 
 @mock.patch("yelp_kafka.discovery.get_region_cluster", autospec=True)

yelp_kafka/__init__.py

@@ -2,5 +2,5 @@
 from __future__ import absolute_import
 from __future__ import unicode_literals
 
-__version__ = "4.17.1"
+__version__ = "5.0.0"
 version_info = tuple(map(int, __version__.split('.')))