Support doseq for urlencode #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,10 +30,16 @@ def _pairs(obj): | |||
| return obj.iteritems() if isinstance(obj, dict) else obj | |||
|
|
|||
|
|
|||
| def urlencode(query, *args, **kwargs): | |||
| def urlencode(query, doseq=0): | |||
There was a problem hiding this comment.
Why a 0 instead of False? May be a docstring for doseq as well.
There was a problem hiding this comment.
Just copying what the stdlib does, not sure why it's done that way.
There was a problem hiding this comment.
Technically you can reassign True in 2.x, but not 0. So there IS that, hah
|
lgtm. |
| import urllib | ||
| import urlparse | ||
|
|
||
| from yelp_uri import urllib_utf8 | ||
|
|
||
|
|
||
| _suites = ['unicode'] |
There was a problem hiding this comment.
heh, leftovers from testify days, can delete
|
testing: 🐵 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #13
I ran into some flake8 errors, which are the other changes here.