Improve end of url detection #23
Conversation
| regex_assert.finds_url('http://example.com{blah', 'http://example.com') | ||
| regex_assert.finds_url('http://example.com{blah}', 'http://example.com') | ||
| regex_assert.finds_url('http://example.com/foo{', 'http://example.com/foo') | ||
|
|
There was a problem hiding this comment.
This should be a separate test and probably use @pytest.mark.parametrize
There was a problem hiding this comment.
I'm making the change, thanks for letting me know about @pytest.mark.parametrize. Now each test case shows up individually!
| @@ -5,7 +5,7 @@ | |||
| def main(): | |||
| setup( | |||
| name='yelp_uri', | |||
| version='1.2.0', | |||
| version='2.0.0', | |||
There was a problem hiding this comment.
I don't see any breaking changes here?
There was a problem hiding this comment.
Buck promoted tlds module to its own package in a separate pull request and those changes have already been merged. You're correct, these changes are only patches and not major/minor. I can remove this and let whoever pushes the package to handle bumping the version, is that the correct procedure?
There was a problem hiding this comment.
that's what I'd do. I generally avoid bumping versions in PRs anyway and leave it up to the maintainers to change the number and release (even when I'm the maintainer). It also has the added benefit of avoiding merge conflicts with others :)
There was a problem hiding this comment.
This has been removed from the PR.
ipwnponies
force-pushed
the
improve_end_url_detection
branch
from
e882e41
to
22f88f3
Compare
This is for the detection of uri to avoid including brackets and braces. Previously,
http://example.com[was being picked up as the whole url.