Intl 36 eoin fix tld url links #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,7 +4,7 @@ | |||
| from yelp_uri import RFC3986 | |||
|
|
|||
|
|
|||
| domains = r"com|ca|net|org|edu|gov|biz|info|mobi|name|us|uk|fr|au|be|ch|de|es|eu|it|tv|cn|jp" | |||
| domains = r"com|ca|net|org|edu|gov|biz|info|mobi|name|us|uk|fr|au|be|ch|de|es|eu|it|tv|cn|jp|ar|cl|hk|br" | |||
There was a problem hiding this comment.
we should find a way to get a more-canonical list of these since this doesn't currently scale.
There was a problem hiding this comment.
Agreed, this was meant to be temporary. I haven't really started looking into better changes yet.
added 3 commits
September 10, 2014 10:08
…Nuge/yelp_uri into INTL-36_eoin_fix_tld_url_links Conflicts: tests/search_test.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: INTL-36. This makes the added TLD URLs appear as links, instead of the URL being linked up to the '.com' etc domain.
Note: I only added one test, because it seems from the tests that we're not going for full code coverage of added domains (and I suppose that would be impossible). What works for com.br will also work for the other domains.