Eoin add domains script #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,7 +29,8 @@ changedir = docs | |||
| commands = sphinx-build -b html -d build/doctrees source build/html | |||
|
|
|||
| [flake8] | |||
| max-line-length=131 | |||
| # Ignores line length limits. | |||
| ignore = E501 | |||
There was a problem hiding this comment.
would rather you revert this and put # noqa on the end of the really-long-regex-line
There was a problem hiding this comment.
Didn't know you could! asottile++
I also added the '# noqa' to the output of the script.
| "Could not get the domains from the given URL. Perhaps the IANA" | ||
| "has changed the location of the file or it no longer exists." | ||
| ) | ||
| return e.reason |
add tests, better printout, rename domains to tlds
|
Looks like you can remove the --omit from tox.ini and then I'll shipit :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a script to generate the "domains = ..." regex from the IANA maintained file at http://data.iana.org/TLD/tlds-alpha-by-domain.txt. (I didn't add any tests because it's a small script which has to be manually copy/pasted anyways--it's otherwise never actually used in code.)