-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eoin add domains script #7
Conversation
@@ -29,7 +29,8 @@ changedir = docs | |||
commands = sphinx-build -b html -d build/doctrees source build/html | |||
|
|||
[flake8] | |||
max-line-length=131 | |||
# Ignores line length limits. | |||
ignore = E501 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would rather you revert this and put # noqa on the end of the really-long-regex-line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't know you could! asottile++
I also added the '# noqa' to the output of the script.
"Could not get the domains from the given URL. Perhaps the IANA" | ||
"has changed the location of the file or it no longer exists." | ||
) | ||
return e.reason |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd change this to raise
add tests, better printout, rename domains to tlds
Looks like you can remove the --omit from tox.ini and then I'll shipit :) |
Added a script to generate the "domains = ..." regex from the IANA maintained file at http://data.iana.org/TLD/tlds-alpha-by-domain.txt. (I didn't add any tests because it's a small script which has to be manually copy/pasted anyways--it's otherwise never actually used in code.)