Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

item_id_to_variable_map, variable_ranges.csv inconsistencies #28

Closed
Saqibm128 opened this issue Nov 21, 2017 · 2 comments
Closed

item_id_to_variable_map, variable_ranges.csv inconsistencies #28

Saqibm128 opened this issue Nov 21, 2017 · 2 comments
Assignees
@turambar
Labels
bug

Comments

@Saqibm128
Copy link
Contributor

Currently, names for variables are inconsistent between the two. For example, item_id_to_variable_map.csv has a variable called "Heart Rate" while variable_ranges.csv has a variable called "Heart rate". This may not seem like much, but it is enough for clean functions and range checking functions to fail to recognize the same variable; a new column called Heart rate is created and populated solely with the impute value (i.e. the assumed normal heart rate of 86 bpm).

Because of #25, the issue is not too important in the current implementation, but it should be considered if remove_outliers_for_variables is ever run on the data.
@turambar turambar mentioned this issue Jan 11, 2018
Merged
@turambar
Copy link
Collaborator

I have a fix for this in #32. Take a look and provide feedback, if you will!

@turambar turambar self-assigned this Jan 11, 2018
@turambar turambar added the bug label Jan 11, 2018
turambar added a commit that referenced this issue Jan 16, 2018
@turambar
Merge pull request #32 from YerevaNN/dck_preproc_fixes
4dd6dde 
- fixed inconsistencies between ITEMID map and variable ranges (#28)
- when making indexed assignments to DataFrame, use the more proper "view" syntax (#24)
- replaced deprecated `DataFrame.from_csv` syntax with `pandas.read_csv`
- minor tweaks here and there
@turambar
Copy link
Collaborator

Merged #32

This was referenced Jan 26, 2018
Closed
Closed
hrayrhar added a commit that referenced this issue Jan 27, 2018
@hrayrhar
Undo two changes which created differences in the created datasets.
46f08bd 
- The first one is from #23. The situation is described in #40.
- The second one is related to #28. #41 addresses this.y
@hrayrhar hrayrhar mentioned this issue Aug 26, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turambar turambar

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@turambar @Saqibm128