Skip to content

Commit

Permalink
fix(reaction): show comment message only if needed
Browse files Browse the repository at this point in the history
  • Loading branch information
J9rem committed Jan 16, 2023
1 parent c23dfbe commit aef60ef
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 6 deletions.
3 changes: 2 additions & 1 deletion tools/bazar/fields/ReactionsField.php
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,8 @@ protected function renderStatic($entry)
'userReaction' => $userReactions,
'oldIdsUserReactions' => $oldIdsUserReactions,
'maxReaction' => self::MAX_REACTIONS,
'pageTag' => $currentEntryTag
'pageTag' => $currentEntryTag,
'showCommentMessage' => !empty($entry['bf_commentaires']) && $entry['bf_commentaires'] == 'oui'
]);
}

Expand Down
9 changes: 5 additions & 4 deletions tools/bazar/presentation/javascripts/form-edit-template.js
Original file line number Diff line number Diff line change
Expand Up @@ -642,6 +642,11 @@ var templates = {
const base = $(element).closest(".acls-field.form-field")
$(element).addClass("initialized")

var nameInput = $(base).find("input[type=text][name=name]")
if (nameInput.val().trim().length == 0 ||
nameInput.val().trim() == 'bf_acls' ){
nameInput.val('bf_commentaires')
}

var visibleSelect = $(base).find("select[name=askIfActivateComments]")
var selectedValue = visibleSelect.val()
Expand All @@ -650,10 +655,6 @@ var templates = {
.find(".form-group.fieldLabel-wrap,.form-group.hint-wrap,.form-group.name-wrap,.form-group.value-wrap")
if ([1,'1'].includes(selectedValue)){
subElements.show()
var nameInput = $(base).find("input[type=text][name=name]")
if (nameInput.val().trim().length == 0){
nameInput.val('bf_commentaires')
}
var commentInput = $(base).find("select[name=comment]")
var currentValue = commentInput.val()
if (Array.isArray(currentValue) &&
Expand Down
2 changes: 1 addition & 1 deletion tools/bazar/templates/fields/_reactions.twig
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{% extends '@core/reactions.twig' %}

{% block extra %}
{%- if connected -%}
{%- if connected and showCommentMessage -%}
<em>{{ _t('BAZ_SHARE_YOUR_COMMENT') }}</em>
{%- endif -%}
{% endblock extra %}

0 comments on commit aef60ef

Please sign in to comment.