Feat/better comments #1160
Merged
Feat/better comments #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @seballot @Lab-8916100448256 @oiseauroch , if you have time to read and test this pr, it would be appreciated! |
|
Noooon !! :D il faut rebaser feat/better-comments sur doryphore-dev, pas merger doryphore-dev dans feat/better-comment :) J'ai force push ta branch pour corriger ça Sinon le code c'est bon pour moi ! juste je me demande si on devrait pas désactiver le formatage automatique sur nos éditeur le temps qu'il y ait un lint général sur tous les fichiers, car ça pollue pas mal la relecture. J'ai testé la feature ça marche niquel ! |
seballot
force-pushed
the
feat/better-comments
branch
from
8dbc020
to
bb18ea0
Compare
seballot
approved these changes
May 19, 2024
|
arg toujours des gaffes de merge git... sorry.. Merci pour la relecture! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of pull request / Description de la demande d'ajout