Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird Button Shape #11

Open
LovecraftianGodsKiller opened this issue Jan 4, 2023 · 7 comments
Open

Weird Button Shape #11

LovecraftianGodsKiller opened this issue Jan 4, 2023 · 7 comments
Assignees
Labels
calculator Issues, pull requests or discussions concerning the calculator mode. code-issue A result, feature or property in the app that does not yield the correct result due to known changes

Comments

@LovecraftianGodsKiller
Copy link

There's a problem where the shapes of the buttons for the calculator are shaped correctly. I have a Samsung Galaxy Z Flip 4 and my guess is that it's just a scaling issue seeing as the phone is much taller than most other phones out there.
Screenshot_20230104_080841_yetCalc

@Yet-Zio
Copy link
Owner

Yet-Zio commented Jan 4, 2023

Hello @LovecraftianGodsKiller, yes this is a scaling issue as I never tested it on the size scale of a foldable. Will look into this once I get enough time, probably a separate layout for screen sizes such as this. Sorry for the inconvenience caused :(

@Yet-Zio Yet-Zio self-assigned this Jan 4, 2023
@Yet-Zio Yet-Zio added bug Something isn't working code-issue A result, feature or property in the app that does not yield the correct result due to known changes and removed bug Something isn't working labels Jan 4, 2023
@Baker0o7
Copy link

Baker0o7 commented Jan 4, 2023

Hi sir thanks I kindly suggest if you make the shape circular instead of oval shape

@Yet-Zio
Copy link
Owner

Yet-Zio commented Jan 5, 2023

Hi @Baker0o7, thanks for the suggestion, however this is a scaling issue. I need to make a separate layout or drawables for supporting taller screen sizes like that of a foldable.

@Yet-Zio Yet-Zio added the calculator Issues, pull requests or discussions concerning the calculator mode. label Jan 5, 2023
@moriel5
Copy link

moriel5 commented Jan 10, 2023

A Razer Phone 2 here, so not a foldable, just a standard 9:16 aspect ratio screen with no notch, and the scaling is wrong here as well, with the buttons looking squashed.

@dannyhand
Copy link

Same with my Galaxy Note 20 Ultra. I keep my phone at 513dp minimum width (Settings > Developer Options > Drawing > Minimum Width) if that helps.

@Yet-Zio
Copy link
Owner

Yet-Zio commented Jan 10, 2023

@moriel5 and @dannyhand thank you for your reports.

@moriel5 judging by your phone size(5.7 inches), do the bottom buttons get cut off or does it look squashed similar to the first case? Would you be willing to send a screenshot if possible?

@dannyhand for you I think its a case of really tall screens, I think its 6.9in for you. which will be fixed once I release a layout with support for larger screens.

@moriel5
Copy link

moriel5 commented Jan 10, 2023

@Yet-Zio I am sorry I had forgotten to mention this crucial information, however my display resolution is currently set to 1080p, with a custom DPI of 300 and minimum smallest width of 576dp, in order to make things closer to the default 1440p resolution, until I find time to replace the ROM and use this device as a daily driver.

It's similar to, yet different from the first example, since nothing is cut off, however the spacing between the keys remains normal, it is only the buttons that are compressed.

Here is the screenshot:
.

Edit: I see that spacing is expanded a bit, just not as much as in the first example, however it would appear as if it is the same issue.

Yet-Zio pushed a commit that referenced this issue Jun 1, 2023
…kotlin.android-1.8.21

Bump org.jetbrains.kotlin.android from 1.8.0 to 1.8.21
Yet-Zio pushed a commit that referenced this issue Jul 28, 2023
…athparser.org-mxparser-5.x

Update dependency org.mariuszgromada.math:MathParser.org-mXparser to v5.2.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
calculator Issues, pull requests or discussions concerning the calculator mode. code-issue A result, feature or property in the app that does not yield the correct result due to known changes
Projects
None yet
Development

No branches or pull requests

5 participants